Week-2 Assignment Complete#4
Open
wandrew8 wants to merge 2 commits intofrontend-application-development-uw20:masterfrom
Open
Week-2 Assignment Complete#4wandrew8 wants to merge 2 commits intofrontend-application-development-uw20:masterfrom
wandrew8 wants to merge 2 commits intofrontend-application-development-uw20:masterfrom
Conversation
t1mwillis
reviewed
May 6, 2020
| function App() { | ||
| return ( | ||
| <div className="app"> | ||
| <section> |
There was a problem hiding this comment.
Also very nice DOM structure here, very easy to read.
t1mwillis
reviewed
May 6, 2020
| </section> | ||
|
|
||
| <section> | ||
| <h1>In case you missed it</h1> |
There was a problem hiding this comment.
A minor nit: typically SEO people will complain that a page should only have one h1 tag.
t1mwillis
reviewed
May 6, 2020
| .forYou { | ||
| margin: 2rem; | ||
| display: grid; | ||
| grid-template-columns: repeat(auto-fill, minmax(500px, 1fr)); |
t1mwillis
reviewed
May 6, 2020
| } | ||
|
|
||
| addBookmark() { | ||
| this.setState({ bookmarked: !this.state.bookmarked }) |
t1mwillis
reviewed
May 6, 2020
| } | ||
| }; | ||
|
|
||
| Author.propTypes = { |
There was a problem hiding this comment.
You can also declare this within the class, using the static keyword and then I think PropTypes is capitalized.
t1mwillis
reviewed
May 6, 2020
| constructor(props) { | ||
| super(props); | ||
| this.state = { | ||
|
|
t1mwillis
reviewed
May 6, 2020
| import React from 'react'; | ||
| import Author from '../components/Author'; | ||
| import { PropTypes } from 'prop-types'; | ||
| import '../App.scss'; |
There was a problem hiding this comment.
Do you need to import App.scss into each component?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Week 2 HW Submission
Please fill out the information below in order to complete your assignment. Feel free to update this comment later if necessary.