homework done#5
Open
tanveeriali wants to merge 3 commits intofrontend-application-development-uw20:masterfrom
Open
homework done#5tanveeriali wants to merge 3 commits intofrontend-application-development-uw20:masterfrom
tanveeriali wants to merge 3 commits intofrontend-application-development-uw20:masterfrom
Conversation
added 3 commits
April 20, 2020 11:26
bhague1281
reviewed
May 19, 2020
| @@ -0,0 +1,22 @@ | |||
| import React from 'react'; | |||
| import missedArticles from './missed-articles.json'; | |||
| import Box from './Box'; | |||
Contributor
There was a problem hiding this comment.
When possible, I'd recommend being more specific with variable names so that people looking at your code can quickly tell what things are. For example, Article as opposed to Box, or months as opposed to m. Just a nitpick though.
bhague1281
reviewed
May 19, 2020
| const author = this.props.author; | ||
| const mIndex = date.getMonth() | ||
| const day = date.getDate() | ||
| const month = m[mIndex] |
bhague1281
reviewed
May 19, 2020
| "@testing-library/user-event": "^7.2.1", | ||
| "react": "^16.13.1", | ||
| "react-dom": "^16.13.1", | ||
| "react-scripts": "3.4.1" |
Contributor
There was a problem hiding this comment.
Don't forget to save dependencies (like prop-types) when installing
bhague1281
reviewed
May 19, 2020
| <div className='words'> | ||
| <Content title={article.title} description={article.description}/> | ||
| <Meta date={article.postedDate} minutes={article.minutesToRead} author={article.author} /> | ||
| </div> |
Contributor
There was a problem hiding this comment.
Missing audio available/member preview
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Week 2 HW Submission
Please fill out the information below in order to complete your assignment. Feel free to update this comment later if necessary.