completed homework for week 2#6
Open
tthaman wants to merge 3 commits intofrontend-application-development-uw20:masterfrom
Open
completed homework for week 2#6tthaman wants to merge 3 commits intofrontend-application-development-uw20:masterfrom
tthaman wants to merge 3 commits intofrontend-application-development-uw20:masterfrom
Conversation
t1mwillis
reviewed
May 6, 2020
| <Col> | ||
| <img alt='author' src={image} height={50} width={50} style={imgStyle}/> | ||
| </Col> | ||
| <Col xs={6}> |
t1mwillis
reviewed
May 6, 2020
| ) | ||
| } | ||
|
|
||
| AuthorInfo.propTypes = { |
There was a problem hiding this comment.
Nice! These can also be declared within the class using the static keyword.
t1mwillis
reviewed
May 6, 2020
| <Container> | ||
| <h5>For You</h5> | ||
| <Row md={2} className='homeRow'> | ||
| <Col><YourArticles data={yourData[0]}/></Col> |
There was a problem hiding this comment.
I think we were looking for something like
yourData.map((data,index) =>
return (
<Col>
<YourArticles data={data} key={index} />
</Col>
))
t1mwillis
reviewed
May 6, 2020
| import PropTypes from 'prop-types'; | ||
|
|
||
| const YourArticles = props => { | ||
| const {image, hasAudioAvailable, memberPreview, title, description, link } = {...props.data}; |
There was a problem hiding this comment.
Suggested change
| const {image, hasAudioAvailable, memberPreview, title, description, link } = {...props.data}; | |
| const {image, hasAudioAvailable, memberPreview, title, description, link } = props.data |
{...props.data} is using the ES6 spread operator to take all of props.data object's keys and wrap them in a new object. props.data = {...props.data}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Week 2 HW Submission
Please fill out the information below in order to complete your assignment. Feel free to update this comment later if necessary.
2--fairly comfortable with react portion but 5 on the styling
complete but doesn't render just like the example