Sven Otto week 3 homework#1
Open
Bl4ckH4wkGER wants to merge 2 commits intofrontend-application-development-uw20:masterfrom
Open
Sven Otto week 3 homework#1Bl4ckH4wkGER wants to merge 2 commits intofrontend-application-development-uw20:masterfrom
Bl4ckH4wkGER wants to merge 2 commits intofrontend-application-development-uw20:masterfrom
Conversation
added 2 commits
April 26, 2020 07:45
bhague1281
reviewed
May 31, 2020
| import ShopItems from './shopitems' | ||
| import CartItems from './cartitems' | ||
| import { FontAwesomeIcon } from '@fortawesome/react-fontawesome'; | ||
| import { faRoute, faPassport, faShoppingCart } from '@fortawesome/free-solid-svg-icons'; |
Contributor
There was a problem hiding this comment.
When using these libraries, you'll want to make sure that they're in the package.json file. Ran into a compile error because they weren't installed when I pulled the code down.
|
|
||
| class CartItems extends React.Component { | ||
| static propTypes = { | ||
| cartitems: PropTypes.arrayOf( |
Contributor
There was a problem hiding this comment.
Nice job being specific with the proptypes 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Week 3 HW Submission
Please fill out the information below in order to complete your assignment. Feel free to update this comment later if necessary.