Completed homework#7
Open
tthaman wants to merge 2 commits intofrontend-application-development-uw20:masterfrom
Open
Completed homework#7tthaman wants to merge 2 commits intofrontend-application-development-uw20:masterfrom
tthaman wants to merge 2 commits intofrontend-application-development-uw20:masterfrom
Conversation
bhague1281
reviewed
May 31, 2020
| } | ||
|
|
||
| props.data.forEach((rentalObj) => { | ||
| rentals.push( |
Contributor
There was a problem hiding this comment.
Alternatively you can also use .map. e.g. const rentals = props.data.map(rentalObj => ...)
| <div style={{display:'inline-block', fontSize:'12px', paddingBottom:'15px'}}> | ||
| <div>{item.title}</div> | ||
| <div>${item.cost}</div> | ||
| <Button variant={"primary"} onClick={props.removeItem} value={JSON.stringify(item)}>Remove Item</Button> |
Contributor
There was a problem hiding this comment.
Interesting use of using the value attribute on the button. Looks like it works just the same!
| removeItem = (e) => { | ||
| const rentalObj = JSON.parse(e.target.value); | ||
| const updatedObj = []; | ||
| this.state.cartItems.forEach(item => { |
Contributor
There was a problem hiding this comment.
Nit: this is a great place to use .filter. e.g. this.state.cartItems.filter(item => item.host !== rentalObj.host)
| const cartItems = props.cartItems; | ||
|
|
||
| function isInCart(rentalObj) { | ||
| let answer = false |
Contributor
There was a problem hiding this comment.
Nit: This is a great place to use .some, which returns a boolean when any of the array items matches the condition in the callback. e.g. const answer = cartItems.some(item => item.host === rentalObj.host.name)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Week 3 HW Submission
Please fill out the information below in order to complete your assignment. Feel free to update this comment later if necessary.