homework complete#4
Open
fbonds wants to merge 3 commits intofrontend-application-development-uw20:masterfrom
Open
homework complete#4fbonds wants to merge 3 commits intofrontend-application-development-uw20:masterfrom
fbonds wants to merge 3 commits intofrontend-application-development-uw20:masterfrom
Conversation
Author
|
I'm not sure what to do here. I need my latest commit (b219366, comment: "updated wireframe, changed requirements") to be what is submitted/reviewed for homework. Tim said this was okay to do. I initially submitted with the stated intent of using Expo, but have subsequently backed away from that and am instead doing an EC2 hosted webpage for my final project. Thank you. |
bhague1281
reviewed
Jun 7, 2020
markup.html
Outdated
| <li>Add/Remove Friends</li> | ||
| <li>Add/Edit/Remove Journal Entry</li> | ||
| <li>Stretch goal: Comment on journal entries</li> | ||
| <li>Stretch goal: Search for Journal entries</li> |
Contributor
There was a problem hiding this comment.
Sounds good 👍 Only recommendation from me would be to put some thought in how you organize the entries. You could organize entries under users, or have entries be its own top-level collection + filter by userId. Both are doable but I think the latter would be easier for displaying a collective list of entries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Week 7 HW Submission
Please fill out the information below in order to complete your assignment. Feel free to update this comment later if necessary.