Add support for Sublime Text v3#3
Open
NickBain wants to merge 7 commits intofruition-partners:masterfrom
Open
Conversation
added 6 commits
December 29, 2014 14:59
Removes v2 support. Add support for sublime v3. Requires JSONv2 SN plugin
-Changed fallback order to try JSONv2 first -Added JSONv2 fallback to run function
-Changed fallback order to try JSONv2 first -Added JSONv2 fallback to run function
Conflicts: README.md
|
Looks good |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code changes required to support sublime v3 (python 3). Maintains backward compatibility with v2.
Mainly formatting, library import changes and decoding/encoding required to support python 3.x used by sublime v3
Other minor changes:
Defaults to using JSONv2 api with v1 fallback (used to do v1 then v2).
There was no fallback on initial file load sync so added.
Updated README
Tested with ST 2&3 on mac and windows.