Peter Ingraham - Topnews Submission #65
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disclaimer goes here that this is rough in parts and has plenty of easy wins left over - spent more time than I should have trying to rewrite user authentication myself before noticing the devise user functions. No specs either, which would happen in reality, same with fancier rendering of the stories.
That said, this does have a Rake task that successfully populates the Articles model with
rake refresh_articles:fetch, and displays. The starring & unstarring works, albeit with crude buttons that require a refresh rather than beautiful star icons which live-toggle. Presumably, in a real-life version, there'd be a cron job (a la Sidekiq period jobs) that would pull the latest articles every so often, and also purge old articles.I've left some unused cruft in for completionism for now - may clean that up later. (This was largely in the "roll my own auth" side which I only belatedly realized was unnecessary.)