feat(publish): add multi-destination S3 support with cache-control and sync-delete#320
Open
loispostula wants to merge 1 commit intomainfrom
Open
feat(publish): add multi-destination S3 support with cache-control and sync-delete#320loispostula wants to merge 1 commit intomainfrom
loispostula wants to merge 1 commit intomainfrom
Conversation
…d sync-delete Support publishing build output to multiple S3 buckets/environments from a single build. Each destination can have its own bucket, prefix, CloudFront distribution, and AWS credentials (via credentials_env_prefix). Backward-compatible: existing single-destination configs work unchanged via resolved_destinations() which synthesizes a "default" destination from legacy top-level fields. Also adds: - Cache-Control headers: .html files get must-revalidate, all others get 1-year immutable (standard SPA pattern) - sync_delete option: removes stale S3 objects not in the current upload (requires bucket_prefix to prevent accidental full-bucket wipe)
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
fslabs-bot
bot
added
the
size/XL
Member
Author
|
/retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support publishing build output to multiple S3 buckets/environments from a single build. Each destination can have its own bucket, prefix, CloudFront distribution, and AWS credentials (via credentials_env_prefix).
Backward-compatible: existing single-destination configs work unchanged via resolved_destinations() which synthesizes a "default" destination from legacy top-level fields.
Also adds: