Skip to content

Conversation

@shcheklein
Copy link
Contributor

Similar to fsspec/gcsfs#718

To be able to refer to a file properly (in case multiple uploads happening simultaneously to the same path), we want to grab generation from the response. S3 already does this.

@shcheklein
Copy link
Contributor Author

@martindurant do you know by chance who is maintaining the project and could release this change?

@kyleknap
Copy link
Collaborator

kyleknap commented Dec 11, 2025

@shcheklein thanks for contribution! Populating the updated version_id after a completed upload seems reasonable to me especially since s3fs is already doing this and you have a similar change out for gcsfs.

I'll have more cycles next week to take a deeper review but some initial things we probably want to address now are:

  1. Let's populate the version_id only if the upstream file system is version_aware. Looks like s3fs has similar logic
  2. It would be great if we can get test cases added to make sure we the version_id is getting set for the different upload branches where it is being set now for version aware filesystems. It would also be good to have a test case too where we don't set the version_id if the filesystem is not version aware.
  3. Add a small changelog entry here for the enhancement.

@shcheklein shcheklein force-pushed the fix-capture-version-on-write branch from a9618f5 to 4eaa094 Compare December 21, 2025 01:36
@shcheklein shcheklein force-pushed the fix-capture-version-on-write branch from 4eaa094 to 70c345d Compare December 21, 2025 01:40
@shcheklein
Copy link
Contributor Author

Hi @kyleknap , thanks for the feedback. I've addressed all the items.

Azurite doesn't support versioning - thus we use mocks in tests. I think that should be fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants