Skip to content

Fail elegantly on files_list_folder and temporary link not found #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
beninada wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fail elegantly on files_list_folder and temporary link not found #22

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions dropboxdrivefs/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ def ls(self, path, detail=True, recursive=False, **kwargs):
)
except ApiError as error:
logging.warning(error)
return None
return []
else:
items = list_item.entries
while list_item.has_more:
Expand Down Expand Up @@ -128,7 +128,10 @@ def _open(

path = path.replace("//", "/")
if mode == "rb":
url = self.dbx.files_get_temporary_link(path).link
try:
url = self.dbx.files_get_temporary_link(path).link
except ApiError:
raise FileNotFoundError(f"Error getting temporary link for {path}")
return webhdfs.WebHDFile(
self,
url,
Expand Down