CI: fixed build and test, polished them, prepare for publishing #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to make clippy happy
TODO: leverage PDM for modern package mgmt
19 tasks
wey-gu
changed the title
wey-gu
force-pushed
the
fix_ci
branch
4 times, most recently
from
c42f933 to
96937f6
Compare
wey-gu
force-pushed
the
fix_ci
branch
7 times, most recently
from
2453a10 to
82554b5
Compare
wey-gu
force-pushed
the
fix_ci
branch
2 times, most recently
from
6b74d47 to
911d508
Compare
Collaborator
Author
|
@Xuanwo this is good to be merged now :) |
Xuanwo
approved these changes
Jan 6, 2025
| pip uninstall -y opendalfs opendalfs_service_memory opendalfs_service_s3 || true | ||
| rm -rf dist dist_combined | ||
|
|
||
| # PyPI publishing job (commented out for future use) |
Collaborator
There was a problem hiding this comment.
Let's use github OIDC for package uploads (so we don't need static tokens): https://github.com/apache/opendal/blob/6ca3eabc0cc5ad2b5e123acc215b62329bbdbf18/.github/workflows/release_python.yml#L105-L130
We can also upload to https://test.pypi.org/legacy/ to test and verify.
But I believe they are good to have in the future and not a blocker of merging this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.