Added methods and test cases for OpendalBufferedFile #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Hi @Xuanwo, could you please take a look when you get a chance and share your feedback? |
Xuanwo
reviewed
Jun 8, 2025
Collaborator
Xuanwo
left a comment
Xuanwo
left a comment
There was a problem hiding this comment.
Thank you for working on this!
| def _fetch_range(self, start: int, end: int) -> bytes: | ||
| """Download data between start and end.""" | ||
| logger.debug(f"Fetching bytes from {start} to {end} for {self.path}") | ||
| data = self.fs.fs.read(self.path) # sync operator |
Collaborator
There was a problem hiding this comment.
We now have native support for read(self.path, offset, size) after apache/opendal#6086 was merged. Would you like to create an issue to track this, so we can update our usage and avoid reading the entire file?
| def _commit_upload(self) -> None: | ||
| """Ensure upload is complete""" | ||
| pass | ||
| """Write the full buffer to the backend once""" |
Collaborator
There was a problem hiding this comment.
OpenDAL has it's own buffer, so we just need to implement write for OpendalBufferedFile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue is this PR linked to?
This PR is in continuation of the discussion [#24].
What changes are included in this PR?
Support for the below methods:
Added test cases
Minor fixes to linting