fix issues with exception handling. #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p and rospy Signed-off-by: Barry Xu <barry.xu@sony.com>
fujitatomoya
force-pushed
the
topic-noetic-devel-uds-support
branch
from
24a25ad to
ce1f433
Compare
fujitatomoya
force-pushed
the
topic-noetic-devel-uds-support
branch
from
ce1f433 to
a839eef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a problem with the exception handling in _tcp_server_uds_callback, it was using e[0] instead of e.args[0].
Further inspection showed some other exceptions could never be reached, in write_data().
Also, the linter pointed out a couple of missing params, and a couple of extra params.