Specify an empty body for NIL bodies.#135
Open
mtstickney wants to merge 1 commit intofukamachi:masterfrom
Open
Specify an empty body for NIL bodies.#135mtstickney wants to merge 1 commit intofukamachi:masterfrom
mtstickney wants to merge 1 commit intofukamachi:masterfrom
Conversation
Wookie's docs for SEND-RESPONSE specify that it sets Content-Length if the :body argument is specified, so we should pass it for explicitly supplied bodies that are NIL. Without it, Content-Length won't be set and the browser will hang waiting for the connection to close.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wookie's docs for SEND-RESPONSE specify that it sets
Content-Length if the :body argument is specified, so we should
pass it for explicitly supplied bodies that are NIL. Without
it, Content-Length won't be set and the browser will hang
waiting for the connection to close.
Note: I just got a PR merged for wookie to fix another issue with NIL
bodies in wookie that causes the same behavior, so if you're going
to test you'll want to pull the latest wookie tip.