Fix TCPServer address detection failing#66
Open
aschampion wants to merge 1 commit intofunkelab:masterfrom
Open
Fix TCPServer address detection failing#66aschampion wants to merge 1 commit intofunkelab:masterfrom
aschampion wants to merge 1 commit intofunkelab:masterfrom
Conversation
The _get_address method uses a UDP-to-8.8.8.8 method to find the default route IP, but in some environments this may not be the correct interface or this method may not work. For example, macOS's application firewall blocks recv on non-loopback interfaces, causing ENOTCONN on all TCP tests. Add _validate_address to verify the detected IP works with a loopback TCP test, falling back to 127.0.0.1. Add optional host parameter in Server and TCPServer for explicit address configuration when needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discovered while attempting to run tests for #65
The _get_address method uses a UDP-to-8.8.8.8 method to find the default
route IP, but in some environments this may not be the correct interface
or this method may not work. For example, macOS's application firewall
blocks recv on non-loopback interfaces, causing ENOTCONN on all TCP
tests. Add _validate_address to verify the detected IP works with a
loopback TCP test, falling back to 127.0.0.1. Add optional host
parameter in Server and TCPServer for explicit address configuration
when needed.
LLM disclosure: while I diagnosed and debugged the root issue, LLMs were used to exclude other causes and draft fixes. But all code here has been human reviewed or created.