Skip to content

PR de correção #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
yuzokamoto wants to merge 68 commits into
base: correcao
Choose a base branch
from
Open

PR de correção #20

yuzokamoto wants to merge 68 commits into from

Conversation

@yuzokamoto
Copy link

@yuzokamoto yuzokamoto commented Apr 28, 2021

Não precisa mergear!

Kell Lanes and others added 30 commits April 19, 2021 12:07
Repo create
39d050b
create routes
21c4218
@MaduAuler
Merge pull request #1 from future4code/branch-lanes1-projeto-pokedex
289078a 
create routes
@MirandaFayra
Adicionar Colecao
03546c1
@MirandaFayra
Merge pull request #2 from future4code/feat/colecao
43f27be 
Adicionar Colecao
@MaduAuler
Link
d475ce2
@MaduAuler
Merge pull request #3 from future4code/madu
78074b0 
Link
@MirandaFayra
Update README.md
a645399
@MaduAuler
Update README.md
1964762
@MirandaFayra
Update README.md
a1e057c
@MirandaFayra
Update README.md
3dacc61
@MirandaFayra
Update README.md
ce98352
@MirandaFayra
Estruturar Header
b08b90d
@MirandaFayra
Arrumar header
ffff7e6
@MirandaFayra
Criar layout basico footer
e93635e
@MirandaFayra
Merge pull request #4 from future4code/header
49183dc 
Header
cardPokemon , grip homepage
33e30de
@laneskell
Merge branch 'master' into branch-lanes2-grid-projeto-pokedex
893777b
@laneskell
Merge pull request #5 from future4code/branch-lanes2-grid-projeto-pok…
2bd5521 
…edex

cardPokemon , grip homepage
@laneskell
Update HomePage.js
10c2e8a 
ajust de commit const pagehome duplicada
@laneskell
Merge pull request #6 from future4code/laneskell-patch-1
d126dbc 
Update HomePage.js
a
0fa8962
grid dimensionado com header e footer
24aedd0
@laneskell
Merge pull request #7 from future4code/branch-lanes3-projeto-pokedex
aa73f83 
Branch lanes3 projeto pokedex
@MaduAuler
Details
3db2d3e
@MirandaFayra
Merge pull request #8 from future4code/madu2
fd0427e 
Details
estado global definido - context e get home funcionando
f9b0788
função adcionar e remover pokemon
4d6a225
@laneskell
Merge pull request #9 from future4code/branck-lanes5
3232972 
função adcionar e remover pokemon
@MaduAuler
DetailsPage/coordinator
def6662
MirandaFayra and others added 29 commits April 21, 2021 14:45
@MirandaFayra
Update README.md
d4a9126
@MirandaFayra
Update README.md
ba9bb28
@MirandaFayra
Update README.md
fa95716
@MirandaFayra
Tornar Responsivo
d7598b8
@MirandaFayra
Merge pull request #12 from future4code/feat/detalhes
6b692ab 
Tornar Responsivo
@MirandaFayra
Update README.md
7aa69f9
@MirandaFayra
Update README.md
21ff18a
@MirandaFayra
Tirar rolagem
ab5cbab
@MirandaFayra
Tirar rolagem
e198f3f
@MirandaFayra
Merge pull request #13 from future4code/feat/detalhes
ad88c53 
Feat/detalhes
@MirandaFayra
Update README.md
4dca4df
@MirandaFayra
Update README.md
0b054be
@MirandaFayra
Arrumar footer
a84ebd9
@MirandaFayra
Adicionar alert ao adicionar pokemon
538563a
@MirandaFayra
Merge pull request #15 from future4code/feat/alert
a92edd7 
Adicionar alert ao adicionar pokemon
Paginação button next prev
b58fac0
loading pokedex
c823b6f
erros console
6ad4c71
@laneskell
Merge pull request #14 from future4code/feat/detalhes
f792241 
Arrumar footer
@laneskell
Merge branch 'master' into paginação
05d22c2
@laneskell
Merge pull request #16 from future4code/paginação
452ec85 
Paginação button next prev
ajuste menssagem console
9eae9eb
ajuste menssagem console
cc5dfd1
@laneskell
Merge branch 'master' into limpeza-erros-console
32fdda2
@laneskell
Merge pull request #17 from future4code/limpeza-erros-console
62f9e89 
Limpeza erros console
console ok
c0f3092
@laneskell
Merge pull request #18 from future4code/limpeza-console
576499d 
console ok
@laneskell
ajuste pagination
fcb4bd5
@laneskell
Merge pull request #19 from future4code/paginacaoupdate
5e3cea3 
ajuste pagination
@yuzokamoto
Copy link
Author

yuzokamoto commented Apr 28, 2021 •
edited
Loading

Eae time 13! O projeto de vocês foi avaliado como acima do esperado! 🤩 🤩 🤩
Belo trabalho, adorei a transição animada!
Aqui vão alguns pontos de melhoria:

  • não deixem a node_modules no repo remoto (github online)
  • remover arquivos desnecessários (css, test.js, logo.svg, webVitals, setupTests, etc...)
  • extrair estilos para um arquivo styled.js externo
  • lembrem-se de checar o console para não deixá-lo poluído

Meus parabéns pela dedicação! Continuem nessa garra!!! 👏👏👏

EDIT: excelente READ.me !!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@yuzokamoto @MaduAuler @MirandaFayra @laneskell