Open
Conversation
Author
|
It looks like the tests are failing but that might be something on the CI part that would have to change for 2.0. The tests all pass on my machine for what it's worth.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I upgraded the solution to use .net core 2.0 across the board. I don't know that you'll actually want to merge this PR since you may want to keep the current master for others to use. Maybe creating a new repo or branch for it would be better. Your call for sure.
Other than updating the breaking changes, I did make a couple of updates to be aware of. I changed the port number in appsettings.json to use the default Elasticsearch port (9200) since that's what I had and what most people will have in their default setup. I have no idea about the docker support so maybe that's why you had it that way. Update as you see fit.
Another change was to add explicit dependencies to Json.net. It worked without doing this but it was showing warnings in the Dependencies section regarding a version mismatch.
I also removed all of the EntityFramework dependencies since, at least for me, more than half the reason I am using ES for identity is because I'm not using SQL and/or EF for this project. Anyway, feel free to add them back in if you'd like.
Thanks for putting together this project.