Skip to content

Minor example refactorings #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Minor example refactorings #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions examples/browser/src/components.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { Cached } from "./cached";
export type Vec2 = { x: number; y: number; }

/** A partial 2D vector. */
export type PartialVec2 = { x?: number; y?: number; }
export type PartialVec2 = Partial<Vec2>;

/** An alignment along the x-axis. */
export type HorizontalAlignment = 'leading' | 'center' | 'trailing';
Expand All @@ -22,12 +22,12 @@ export function add(lhs: PartialVec2, rhs: PartialVec2): Vec2 {

/** Subtracts two 2D vectors. */
export function sub(lhs: PartialVec2, rhs: PartialVec2): Vec2 {
return { x: (lhs.x ?? 0) - (rhs.x ?? 0), y: (lhs.y ?? 0) - (rhs.y ?? 0) };
return add(lhs, scale(rhs, -1));
Copy link
Owner

@fwcd fwcd Aug 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah we could do this, my idea was that subtraction is so fundamental that it ought to be as fast as possible, so I'd actually lean towards keeping it as is (though perhaps we'd want to default the parameters to { x = 0, y = 0 } to make it less verbose).

}

/** Scales a 2D vector. */
export function scale(lhs: PartialVec2, rhs: number): Vec2 {
return { x: (lhs.x ?? 0) * rhs, y: (lhs.y ?? 0) * rhs };
export function scale({ x = 0, y = 0 }: PartialVec2, rhs: number): Vec2 {
Copy link
Owner

@fwcd fwcd Aug 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we default these parameters, the vector no longer needs to be a PartialVec2, right?

Suggested change
export function scale({ x = 0, y = 0 }: PartialVec2, rhs: number): Vec2 {
export function scale({ x = 0, y = 0 }: Vec2, rhs: number): Vec2 {

Also it would be great if we could use this trick for add and sub too, for consistency.

return { x: x * rhs, y: y * rhs };
}

/** Swaps the components of a 2D vector. */
Expand Down