Skip to content

Avoid a deprecation warning in FoundationXML when initializing XMLElement instances by initializing them as comments #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nglevin wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Avoid a deprecation warning in FoundationXML when initializing XMLElement instances by initializing them as comments #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sources/OrderedPlistEncoder/Container/KeyedOrderedPlistEncodingContainer.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ struct KeyedOrderedPlistEncodingContainer<Key>: KeyedEncodingContainerProtocol w

private mutating func addChildElement(forKey key: Key) -> XMLElement {
// TODO: Add check for duplicate keys (should we throw an EncodingError?)
let childElement: XMLElement = .init()
let childElement = XMLElement(kind: .comment)
element.addChild(XMLElement(name: "key", stringValue: key.stringValue))
element.addChild(childElement)
return childElement
Expand Down
2 changes: 1 addition & 1 deletion Sources/OrderedPlistEncoder/Container/UnkeyedOrderedPlistEncodingContainer.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ struct UnkeyedOrderedPlistEncodingContainer: UnkeyedEncodingContainer {
}

private mutating func addItemElement() -> XMLElement {
let itemElement: XMLElement = .init()
let itemElement = XMLElement(kind: .comment)
element.addChild(itemElement)
count += 1
return itemElement
Expand Down
2 changes: 1 addition & 1 deletion Sources/OrderedPlistEncoder/OrderedPlistEncoderImpl.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ struct OrderedPlistEncoderImpl: Encoder {

private(set) var element: XMLElement

init(element: XMLElement = .init(), codingPath: [any CodingKey] = []) {
init(element: XMLElement = XMLElement(kind: .comment), codingPath: [any CodingKey] = []) {
self.element = element
self.codingPath = codingPath
}
Expand Down