Skip to content

[GovStack Demo script tcs]#12

Open
abhinavm117 wants to merge 29 commits intofynarfin:masterfrom
abhinavm117:demo_script_tcs
Open

[GovStack Demo script tcs]#12
abhinavm117 wants to merge 29 commits intofynarfin:masterfrom
abhinavm117:demo_script_tcs

Conversation

@abhinavm117
Copy link

Description

  • PR title should have jira ticket enclosed in [].

    Format: [jira_ticket] description

    ex: [phee-123] PR title.
  • Add a link to the Jira ticket.
  • Describe the changes made and why they were made.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Followed the PR title naming convention mentioned above.

  • Acknowledge that we will not merge PRs that are not passing the checks ("green") - it is your (author's) responsibility to get a proposed PR to pass all the checks, not primarily the project's maintainers.

  • The PR title should include a JIRA ticket

  • Design-related bullet points or design document links related to this PR added in the description above.

  • Updated corresponding Postman Collection or API documentation for the changes in this PR.

  • Create/update unit or integration tests for verifying the changes made.

  • Add required Swagger annotation and update API documentation with details of any API changes if applicable

  • Followed the naming conventions as given in https://docs.google.com/document/d/1Q4vaMSzrTxxh9TS0RILuNkSkYCxotuYk1Xe0CMIkkCU/edit?usp=sharing

  • Followed coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.

FYI our guidelines for code reviews same as https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

@abhinavm117 abhinavm117 force-pushed the demo_script_tcs branch 3 times, most recently from 49f4482 to a362ef9 Compare July 11, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants