[PANC-71] Add Integration Tests For Mock Airtel API.#15
Open
sanchit-0 wants to merge 1 commit intofynarfin:developfrom
Open
[PANC-71] Add Integration Tests For Mock Airtel API.#15sanchit-0 wants to merge 1 commit intofynarfin:developfrom
sanchit-0 wants to merge 1 commit intofynarfin:developfrom
Conversation
sanchit-0
force-pushed
the
mock-airtel-api
branch
3 times, most recently
from
efaa4e6 to
f124151
Compare
sanchit-0
force-pushed
the
mock-airtel-api
branch
4 times, most recently
from
5acf5e5 to
e10d445
Compare
sanchit-0
force-pushed
the
mock-airtel-api
branch
from
e10d445 to
c46a1b1
Compare
sanchit-0
commented
Aug 5, 2024
| } | ||
|
|
||
| maven { | ||
| url = uri('https://jfrog.sandbox.fynarfin.io/artifactory/fyn-libs-snapshot') |
Author
There was a problem hiding this comment.
Changes in this file has to be done because jfrog is not working rn
Collaborator
There was a problem hiding this comment.
okay, remove this part once jfrog issue is fixed.
sanchit-0
force-pushed
the
mock-airtel-api
branch
from
c46a1b1 to
8aa0be6
Compare
sanchit-0
force-pushed
the
mock-airtel-api
branch
from
8aa0be6 to
8d702c3
Compare
logoutdhaval
approved these changes
Aug 5, 2024
| testImplementation "com.github.tomakehurst:wiremock-jre8:2.35.0" | ||
| testImplementation 'org.springframework.boot:spring-boot-starter-test' | ||
| implementation 'org.mifos:ph-ee-connector-common:1.8.1-SNAPSHOT' | ||
| implementation 'org.mifos:ph-ee-connector-common:0.0.0' |
Collaborator
There was a problem hiding this comment.
Also, update this to the released version after the jfrog issue is fixed.
| } | ||
|
|
||
| maven { | ||
| url = uri('https://jfrog.sandbox.fynarfin.io/artifactory/fyn-libs-snapshot') |
Collaborator
There was a problem hiding this comment.
okay, remove this part once jfrog issue is fixed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PANC-71 Write Mock APIs for Airtel money.
The integration TCs have been based on the following design:
NOTE: The DTOs required by ph-ee-integration-tests are in
ph-ee-connector-common-0.0.0whereas the repo was usingorg.mifos:ph-ee-connector-common:1.4.1-SNAPSHOT.[].Format:
[jira_ticket] descriptionex: [phee-123] PR title.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Followed the PR title naming convention mentioned above.
Acknowledge that we will not merge PRs that are not passing the checks ("green") - it is your (author's) responsibility to get a proposed PR to pass all the checks, not primarily the project's maintainers.
The PR title should include a JIRA ticket
Design-related bullet points or design document links related to this PR added in the description above.
Updated corresponding Postman Collection or API documentation for the changes in this PR.
Create/update unit or integration tests for verifying the changes made.
Add required Swagger annotation and update API documentation with details of any API changes if applicable
Followed the naming conventions as given in https://docs.google.com/document/d/1Q4vaMSzrTxxh9TS0RILuNkSkYCxotuYk1Xe0CMIkkCU/edit?usp=sharing
Followed coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
FYI our guidelines for code reviews same as https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.