[PHEE-686] Create Ops-app Get transaction request API negative test cases#16
Open
dhruvsonagara wants to merge 5 commits intodevelopfrom
Open
[PHEE-686] Create Ops-app Get transaction request API negative test cases#16dhruvsonagara wants to merge 5 commits intodevelopfrom
dhruvsonagara wants to merge 5 commits intodevelopfrom
Conversation
fynmanoj
requested changes
Aug 9, 2024
There was a problem hiding this comment.
remove this file from this PR if the changes are not relevant
| String endpoint = String.format("%s?sortedOrder=%s", operationsAppConfig.transactionRequestsEndpoint, order); | ||
| String fullUrl = operationsAppConfig.operationAppContactPoint + endpoint; | ||
|
|
||
| logger.info("Calling endpoint with invalid sorting order: {}", fullUrl); |
There was a problem hiding this comment.
this line can be avoided. by either updating line above or the logger line below.
| String sortedBy = "jupiter"; | ||
|
|
||
| String endpoint = String.format("%s?sortedBy=%s", operationsAppConfig.transactionRequestsEndpoint, sortedBy); | ||
| String fullUrl = operationsAppConfig.operationAppContactPoint + endpoint; |
There was a problem hiding this comment.
this line can be avoided. by either updating line above or the logger line below.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
[].Format:
[jira_ticket] descriptionex: [phee-123] PR title.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Followed the PR title naming convention mentioned above.
Acknowledge that we will not merge PRs that are not passing the checks ("green") - it is your (author's) responsibility to get a proposed PR to pass all the checks, not primarily the project's maintainers.
The PR title should include a JIRA ticket
Design-related bullet points or design document links related to this PR added in the description above.
Updated corresponding Postman Collection or API documentation for the changes in this PR.
Create/update unit or integration tests for verifying the changes made.
Add required Swagger annotation and update API documentation with details of any API changes if applicable
Followed the naming conventions as given in https://docs.google.com/document/d/1Q4vaMSzrTxxh9TS0RILuNkSkYCxotuYk1Xe0CMIkkCU/edit?usp=sharing
Followed coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
FYI our guidelines for code reviews same as https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.