Skip to content

fix: harden deployment smoke validation#53

Merged
gabedalmolin merged 1 commit intomainfrom
fix/deploy-smoke-redirect-handling
Mar 11, 2026
Merged

fix: harden deployment smoke validation#53
gabedalmolin merged 1 commit intomainfrom
fix/deploy-smoke-redirect-handling

Conversation

@gabedalmolin
Copy link
Copy Markdown
Owner

Summary

Harden the Railway deployment smoke validation so production deploys do not fail on normal HTTPS redirects or ambiguous base URL configuration.

What changed

  • Added an explicit HTTPS base URL guard in the deploy workflow before smoke validation starts.
  • Updated the production smoke script to follow safe redirects and fail with a clearer message when a non-JSON payload is returned.
  • Clarified the expected RAILWAY_PUBLIC_URL format in the Railway deployment guide.

Validation

  • bash -n scripts/smoke-production.sh
  • npm run lint
  • npm run typecheck
  • npm test
  • npm run test:integration when the change affects infrastructure-backed paths

Risks/Notes

  • This change only affects deployment validation and deployment docs; there are no runtime API changes.
  • The next deploy should still use a canonical HTTPS RAILWAY_PUBLIC_URL value.

@gabedalmolin gabedalmolin force-pushed the fix/deploy-smoke-redirect-handling branch from 5069558 to 46956c4 Compare March 11, 2026 21:04
@gabedalmolin gabedalmolin merged commit f56b1b4 into main Mar 11, 2026
5 checks passed
@gabedalmolin gabedalmolin deleted the fix/deploy-smoke-redirect-handling branch March 11, 2026 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant