Skip to content

fix: make deployment smoke checks more resilient#55

Merged
gabedalmolin merged 1 commit intomainfrom
fix/deploy-smoke-startup-window
Mar 11, 2026
Merged

fix: make deployment smoke checks more resilient#55
gabedalmolin merged 1 commit intomainfrom
fix/deploy-smoke-startup-window

Conversation

@gabedalmolin
Copy link
Copy Markdown
Owner

Summary

Make production smoke validation more resilient to Railway startup timing and return clearer diagnostics when the public URL is misrouted or not yet serving JSON endpoints.

What changed

  • Reworked the production smoke script to poll endpoints with explicit attempt windows instead of failing fast on HTTP 404 responses.
  • Added clearer failure output that reports the last HTTP status code and a payload preview.
  • Documented that RAILWAY_PUBLIC_URL must belong to the same Railway service targeted by RAILWAY_SERVICE.

Validation

  • bash -n scripts/smoke-production.sh
  • npm run lint
  • npm run typecheck
  • npm test
  • npm run test:integration when the change affects infrastructure-backed paths

Risks/Notes

  • This does not hide a wrong public URL; it only gives the deployment more time to become reachable and produces better diagnostics if it still fails.
  • If /health keeps returning 404 after the retry window, the Railway public domain is likely pointing to the wrong service or a stale deployment.

@gabedalmolin gabedalmolin merged commit 4abf725 into main Mar 11, 2026
5 checks passed
@gabedalmolin gabedalmolin deleted the fix/deploy-smoke-startup-window branch March 11, 2026 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant