Skip to content

Enh: sparse model, ppi port, Enh: arbitrary L1, Bug fix: fix group contrast, Enh: add conjunction analysis stub#16

Open
gciccarelli3 wants to merge 33 commits intogablab:masterfrom
gciccarelli3:master
Open

Enh: sparse model, ppi port, Enh: arbitrary L1, Bug fix: fix group contrast, Enh: add conjunction analysis stub#16
gciccarelli3 wants to merge 33 commits intogablab:masterfrom
gciccarelli3:master

Conversation

@gciccarelli3
Copy link
Copy Markdown
Contributor

Enh: fix datasink substitutions in L1

@mgxd
Copy link
Copy Markdown
Collaborator

mgxd commented Oct 19, 2016

@gciccarelli3 the l1 run flag should default to grabbing all runs

@gciccarelli3
Copy link
Copy Markdown
Contributor Author

I believe it does. I just wrapped the normal flow with a conditional to
handle if run_id was not None.

if run_id==None:
    run_list_process = run_ids[0]
else:
    run_list_process = run_id

Lines 615-618 in the commit.

However, this wasn't tested, and the script definitely wasn't tested when
passed multiple tasks.

On Wed, Oct 19, 2016 at 3:38 PM, Mathias Goncalves <notifications@github.com

wrote:

@gciccarelli3 https://github.com/gciccarelli3 the l1 run flag should
default to grabbing all runs


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#16 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AImhwJQWrCzetK9P2rdxil485n1d5K9Cks5q1nHSgaJpZM4Ka5GT
.

MIT VoiceUp: Self Understanding through Vocal Analytics
web: voicesurvey.mit.edu
email: voice_survey@mit.edu
facebook: VoiceUp_MIT
twitter: @VoiceUp_MIT

@gciccarelli3 gciccarelli3 changed the title Enh: arbitrary L1, Bug fix: fix group contrast, Enh: add conjunction analysis stub Enh: sparse model, ppi port, Enh: arbitrary L1, Bug fix: fix group contrast, Enh: add conjunction analysis stub Nov 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants