fix: invert back the stableswap spot price #1094
Conversation
|
Crate versions that have not been updated:
Crate versions that have been updated:
Crate versions that have been downgraded:
Runtime version has not been increased. |
dmoka
changed the title
# Conflicts: # Cargo.lock # pallets/stableswap/Cargo.toml # runtime/hydradx/Cargo.toml # runtime/hydradx/src/lib.rs
enthusiastmartin
left a comment
enthusiastmartin
left a comment
There was a problem hiding this comment.
the change/fix looks ok.
however, i do have question why the need to change various values in the tests ?
eg. fees, issuance etc.
i would expect the tests not to change.
and it needs to resolve the conflicts.
agree, reverted all those changes |
| fee, | ||
| pegs, | ||
| ) | ||
| .map(|p| p.reciprocal())? |
There was a problem hiding this comment.
we should fix the underlaying function rather than inverting the price here.
| &asset_pegs, | ||
| ) | ||
| .ok_or_else(|| ExecutorError::Error(ArithmeticError::Overflow.into()))? | ||
| .reciprocal() |
There was a problem hiding this comment.
i think this is an issue?!
|
Quick benchmark at commit 375b5e6 has been executed successfully. |
Fixes -> #1009