fix(stableswap): reorder peg sources to match sorted assets during pool creation #1266
+321
−21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a stableswap pool with pegs, assets are sorted by ID for consistent ordering, but the corresponding peg sources and current pegs were not reordered to match. This caused pegs to be associated with the wrong assets after sorting.
The fix creates an index mapping before sorting and uses it to reorder both
peg_info.sourceandpeg_info.currentarrays to maintain correct asset-to-peg associations.Related Issue
Fixes: #1164
Motivation and Context
When creating a pool with assets [3, 1, 2] and pegs [Peg3, Peg1, Peg2]:
This caused incorrect price calculations and potential trading failures in stableswap pools using pegged assets.
How Has This Been Tested?
pallets/stableswap/src/tests/peg.rscovering:Checklist