fix: pin srtool docker image version to 1.81.0 #1308
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the srtool build workflow by using Docker directly instead of srtool-cli, with a pinned image version matching
rust-toolchain(1.81.0).srtool-cli ignores
rust-toolchainand always uses the latest container image (1.88.0), causing build failures:Changes
docker rundirectly with pinnedparitytech/srtool:1.81.0imageSRTOOL_VERSIONenv variable for easy version managementsrbuildtarget to use Docker directlysrtool_imageworkflow input (see note below)Note on Removed Input
The
srtool_imageworkflow input has been removed. It never worked as intended - it controlled the srtool-cli git tag (cargo install --tag), not the Docker image version.This is not classified as a breaking change because:
srtool_imageis specified viaworkflow_dispatch, it will simply be silently ignored by GitHub ActionsRelated Issue
Workaround for chevdor/srtool-cli#40:
Motivation and Context
Deterministic builds are critical for blockchain runtimes. The
authorize_upgradehash must be reproducible so validators and the community can verify the runtime WASM matches the source code.By pinning the Docker image version to match
rust-toolchain, we ensure consistent, reproducible builds.How Has This Been Tested?
Checklist: