use Screwcap module to namespace all classes#7
Open
roovo wants to merge 2 commits intogammons:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was just trying this out in a project that already had a Server class defined which was a bit of a pain as there's one defined in screwcap as well....
...so have ensured that all the classes in the gem are namespaced in the Screwecap module.
Tests are all still passing - and I've given it a go for real and haven't hit any probs so I think it's OKay.
I've also tidied up the gemspec and Gemfile to use bundler's gem builder as it's (in my opinion) a bit cleaner than using newgem/hoe or whatever it was that it was going on.
Hope you like - need anything just shout
Cheers doode
roovo