This repository was archived by the owner on Jun 15, 2023. It is now read-only.
Fix issue "Can't resolve 'crypto'"#48
Open
christoph-bittmann wants to merge 4 commits intogardner:masterfrom
Open
Fix issue "Can't resolve 'crypto'"#48christoph-bittmann wants to merge 4 commits intogardner:masterfrom
christoph-bittmann wants to merge 4 commits intogardner:masterfrom
Conversation
busycat
approved these changes
Aug 28, 2022
|
Hi @gardner any updates? Thanks. |
tony19
suggested changes
Mar 21, 2023
| } | ||
|
|
||
| export const createPKCECodes = (): PKCECodePair => { | ||
| const codeVerifier = `${getRandomInt(64, 256)}` |
There was a problem hiding this comment.
This line looks like a bug because it only generates a single random number. The original code generates an array of 64 random bytes, and base-64 encodes that.
Line 22 in 7f72ec5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To make these library usabled in projects that uses React 17 or higher (see discussion here: https://www.npmjs.com/package/crypto As discussed in #33), I replaced nodes build-in crypto module, that was not meant for the browser, with window.crypto object.
Additionally dependencies was updated and cleaned up, ESLint config and linting errors was fixed.
Finally I also rewrite the unittest for AuthService, because it fails bevore.