Handle array properties and assorted fixes #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
February 7, 2018 12:20
Required properties in swagger weren't correctly converted to required puppet properties leading in puppet not checking if a given property was required or not.
Because of a wrong variable name, the swagger description never ends in the puppet type generated.
The generator always assumed items were an hash. But some properties are actually arrays in Kubernetes (ie cluster_roles rules or network policy egress/ingress). This add the necessary bits so that puppet treat those properties as arrays and compares all elements instead of only the first one.
This was annoying and not necessarily useful :)
masterzen
pushed a commit
to daysofwonder/garethr-kubernetes
that referenced
this pull request
Feb 7, 2018
See garethr/puppet-swagger-generator#13 This makes in particular cluster_role.rules usable.
masterzen
pushed a commit
to daysofwonder/garethr-kubernetes
that referenced
this pull request
Feb 7, 2018
See garethr/puppet-swagger-generator#13 This makes in particular cluster_role.rules usable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains a set of fix from @teintuc to the swagger template so that: