This repository was archived by the owner on Jun 23, 2024. It is now read-only.
Make CowdinTranslateParameters lazy and DownloadTask use inputs#19
Open
supersaiyansubtlety wants to merge 2 commits intogbl:fabric_1_19from
Open
Make CowdinTranslateParameters lazy and DownloadTask use inputs#19supersaiyansubtlety wants to merge 2 commits intogbl:fabric_1_19from
supersaiyansubtlety wants to merge 2 commits intogbl:fabric_1_19from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: I'm making a plugin that applies a lot of my conventions to my mod projects, and in its current state I can't configure CrowdinTranslate via my own lazily configured extension.
Also
DownloadTaskusing task inputs instead of a static reference to the extension is important for mulitproject builds.