Conversation
Contributor
|
This is awesome. Didn't know you were working on this already! |
zquestz
reviewed
Aug 21, 2020
zquestz
reviewed
Aug 21, 2020
| // DoubleSpendProofVersion is the prootocol version which added | ||
| // double spend proof relaying. | ||
| // FIXME: What is this supposed to be? | ||
| DoubleSpendProofVersion uint32 = 70016 |
Contributor
There was a problem hiding this comment.
We would just need to come to agreement between the different node implementations. I like just using 70016 myself, but ideally we put this in the spec for other BCH nodes. I know BU is already in the 80k range...
|
Any update on this? :(((( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spec: https://gitlab.com/-/snippets/1883331
TODO:
Validate proof.
Send proof to RPC server and gRPC server.
RPC servers handle dsproof subscriptions. On subscribe should scan mempool to see if any proofs exist. Relay if so.
FetchDSProof mempool method.
Remove dsproofs from mempool on confirmation.
Generate dsproofs when double spend is detected.
Handle orphan proofs.