Skip to content

Conversation

@GCHQDeveloper36
Copy link
Member

Currently reviewerss can 'request changes' or 'approve' when responding to review, but there isn't any way to 'deny' and indicate that the request is unlikely to go any further regardless of changes provided by the submitter.

The most obvious addition is the 'Deny' button when on the response page. To avoid confusion, I've adjusted the colours of the 'request changes' and 'approve' buttons to more clearly highlight the difference between the actions. Definitely room for improvement here in the future. In particular, we're adding yet more frontend-filtering to figure out whether a review is 'archived' or not, which we still want to move to the backend.

There's also some work to categorise 'approve' and 'deny' as 'finalised' states which, whilst not 'locked', would usually indicate a role has provided their final response to the review. We could use this in the future to soft-lock the decision and warn the reviewer if they try to undo or otherwise change their review from a 'final' state into something else.

At the backend, there's some work to provide a 'summarised' response from the responses so far. The main path is from findReviews (used by the frontend) which will now also provide a 'decision' in the response. This decision is calculated by finding the 'latest' response for each role associated with a review, and using some basic logic to figure out what should be classed as the 'current' response for that role.

Still in draft/WIP - there's another commit to come which improves the backend filtering.

@ARADDCC002
Copy link
Member

Closing for now, this can be looked at in the future

@ARADDCC002 ARADDCC002 closed this Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants