fix: support service impl-only type generics#1278
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the service macro generation by introducing a __SERVICE_INTERFACE_ID constant, which is used in the Identifiable trait implementation and invocation_io! macros. This change ensures that generic parameters on the service implementation are correctly scoped. A new test case was added to verify this behavior. Feedback suggests that a similar scoping issue remains for generic base service paths within the overrides attribute, which should be addressed to ensure complete coverage of generic scenarios.
m62624
force-pushed
the
fix/generic-service-macro
branch
from
65b8012 to
b03ff80
Compare
m62624
force-pushed
the
fix/generic-service-macro
branch
from
4c76761 to
0deea41
Compare
m62624
force-pushed
the
fix/generic-service-macro
branch
from
1fdf460 to
25b064d
Compare
m62624
force-pushed
the
fix/generic-service-macro
branch
from
25b064d to
2121753
Compare
vobradovich
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
#[service]for impl-only type generics.For impls like
#[service] impl<T: Bound> Service<T> { ... }, generatedinvocation_io!code ended up in a non-generic*_metamodule while still referencingService<T>, makingTout of scope. Use an internal__SERVICE_INTERFACE_IDinside*_metaso impl generics do not leak into generated meta/params code.