Added license to package.json #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

geelen merged 1 commit into geelen:main from GeraldAdyen:main

Nov 20, 2025

Contributor

GeraldAdyen commented Oct 17, 2025

Added license property and value to the package.json


          Added license to package.json

eacc320

clouatre approved these changes

View reviewed changes

Contributor

clouatre left a comment

Reviewed and tested locally on macOS.

Testing:

✅ All unit tests pass (44/44)
✅ Build succeeds without errors
✅ License field matches existing LICENSE file (MIT)
✅ Valid SPDX license identifier

Why This Matters:

The license field is recommended npm best practice
Helps automated tools identify licensing
Important for npm registry and package consumers
Matches the existing LICENSE file in the repo

Code Quality:

Proper placement in package.json (after author, before repository)
Follows npm package.json conventions
No breaking changes

LGTM! This is a standard and necessary addition to package.json.

geelen merged commit febf4e0 into geelen:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet