Open
Conversation
Member
Author
|
This PR is ready for review. However, I need to conduct a broader investigation into the stability of the ruptures generated with a seed and their variability when the seed is altered. An additional possible test is the extent to which hazard curves from event-based analysis match those produced using the classical approach. |
Contributor
|
I guess this will affect the USA model, the New Madrid cluster. Do you have an idea of how much? Should we backport the fix to the LTS version? Also, you forgot to edit the changelog. |
micheles
reviewed
May 26, 2025
| self._num_ruptures = len(self.data) | ||
| return self._num_ruptures | ||
|
|
||
| @num_ruptures.setter |
Contributor
There was a problem hiding this comment.
I do not understand this. Setting num_ruptures is potentially dangerous as it could break the relation with len(self.data). Why do we need this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the generation of SES with a cluster model and clarifies the parameters required in the various cases supported.