-
Notifications
You must be signed in to change notification settings - Fork 322
fix(claude): pass CLAUDE_CONFIG_DIR to subprocess and fix initial PTY size #1647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ubuntudroid
wants to merge
4
commits into
generalaction:main
Choose a base branch
from
ubuntudroid:sven/fix-claude-statusline-changes-not-applied-7uh
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+184
−0
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
fc5ba4c
fix(claude): pass CLAUDE_CONFIG_DIR to subprocess and fix initial PTY…
ubuntudroid e46aa59
test(shellEnv): add tests for CLAUDE_CONFIG_DIR detection
ubuntudroid 02371c2
fix: address coderabbit review comments
ubuntudroid 87e8053
fix(shellEnv): treat whitespace-only CLAUDE_CONFIG_DIR as unset
ubuntudroid File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,146 @@ | ||
| import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'; | ||
|
|
||
| const execSyncMock = vi.fn(); | ||
|
|
||
| vi.mock('child_process', () => ({ | ||
| execSync: (...args: any[]) => execSyncMock(...args), | ||
| })); | ||
|
|
||
| // Prevent socket-detection calls in detectSshAuthSock from touching real fs | ||
| vi.mock('fs', () => { | ||
| const mock = { | ||
| statSync: vi.fn().mockImplementation(() => { | ||
| throw new Error('ENOENT'); | ||
| }), | ||
| readdirSync: vi.fn().mockReturnValue([]), | ||
| }; | ||
| return { ...mock, default: mock }; | ||
| }); | ||
|
|
||
| describe('getShellEnvVar', () => { | ||
| beforeEach(() => { | ||
| vi.resetModules(); | ||
| vi.clearAllMocks(); | ||
| }); | ||
|
|
||
| it('returns the trimmed value from the shell', async () => { | ||
| execSyncMock.mockReturnValue('/custom/claude/config\n'); | ||
| const { getShellEnvVar } = await import('../../main/utils/shellEnv'); | ||
| expect(getShellEnvVar('CLAUDE_CONFIG_DIR')).toBe('/custom/claude/config'); | ||
| }); | ||
|
|
||
| it('returns undefined when the shell outputs nothing', async () => { | ||
| execSyncMock.mockReturnValue(''); | ||
| const { getShellEnvVar } = await import('../../main/utils/shellEnv'); | ||
| expect(getShellEnvVar('CLAUDE_CONFIG_DIR')).toBeUndefined(); | ||
| }); | ||
|
|
||
| it('returns undefined without calling execSync for invalid var names', async () => { | ||
| const { getShellEnvVar } = await import('../../main/utils/shellEnv'); | ||
| expect(getShellEnvVar('invalid-name')).toBeUndefined(); | ||
| expect(execSyncMock).not.toHaveBeenCalled(); | ||
| }); | ||
|
|
||
| it('returns undefined when execSync throws', async () => { | ||
| execSyncMock.mockImplementation(() => { | ||
| throw new Error('shell unavailable'); | ||
| }); | ||
| const { getShellEnvVar } = await import('../../main/utils/shellEnv'); | ||
| expect(getShellEnvVar('CLAUDE_CONFIG_DIR')).toBeUndefined(); | ||
| }); | ||
| }); | ||
|
|
||
| describe('initializeShellEnvironment — CLAUDE_CONFIG_DIR', () => { | ||
| let savedClaudeConfigDir: string | undefined; | ||
| let savedLang: string | undefined; | ||
|
|
||
| beforeEach(() => { | ||
| vi.resetModules(); | ||
| vi.clearAllMocks(); | ||
|
|
||
| savedClaudeConfigDir = process.env.CLAUDE_CONFIG_DIR; | ||
| savedLang = process.env.LANG; | ||
|
|
||
| delete process.env.CLAUDE_CONFIG_DIR; | ||
|
|
||
| // Set a UTF-8 locale so initializeLocaleEnvironment() exits early and | ||
| // doesn't issue its own execSync calls, keeping the mock simple. | ||
| process.env.LANG = 'en_US.UTF-8'; | ||
|
|
||
| // Default: execSync returns empty (no SSH_AUTH_SOCK from launchctl, no | ||
| // CLAUDE_CONFIG_DIR from shell, no locale vars). | ||
| execSyncMock.mockReturnValue(''); | ||
| }); | ||
|
|
||
| afterEach(() => { | ||
| if (savedClaudeConfigDir === undefined) { | ||
| delete process.env.CLAUDE_CONFIG_DIR; | ||
| } else { | ||
| process.env.CLAUDE_CONFIG_DIR = savedClaudeConfigDir; | ||
| } | ||
|
|
||
| if (savedLang === undefined) { | ||
| delete process.env.LANG; | ||
| } else { | ||
| process.env.LANG = savedLang; | ||
| } | ||
| }); | ||
|
|
||
| it('sets CLAUDE_CONFIG_DIR from the login shell when absent from process.env', async () => { | ||
| execSyncMock.mockImplementation((cmd: string) => { | ||
| if (typeof cmd === 'string' && cmd.includes('CLAUDE_CONFIG_DIR')) { | ||
| return '/shell/custom/claude\n'; | ||
| } | ||
| return ''; | ||
| }); | ||
|
|
||
| const { initializeShellEnvironment } = await import('../../main/utils/shellEnv'); | ||
| initializeShellEnvironment(); | ||
|
|
||
| expect(process.env.CLAUDE_CONFIG_DIR).toBe('/shell/custom/claude'); | ||
| }); | ||
|
|
||
| it('does not override CLAUDE_CONFIG_DIR already present in process.env', async () => { | ||
| process.env.CLAUDE_CONFIG_DIR = '/existing/path'; | ||
| execSyncMock.mockReturnValue('/shell/custom/claude\n'); | ||
|
|
||
| const { initializeShellEnvironment } = await import('../../main/utils/shellEnv'); | ||
| initializeShellEnvironment(); | ||
|
|
||
| expect(process.env.CLAUDE_CONFIG_DIR).toBe('/existing/path'); | ||
| }); | ||
|
|
||
| it('treats whitespace-only CLAUDE_CONFIG_DIR as unset and falls back to shell', async () => { | ||
| process.env.CLAUDE_CONFIG_DIR = ' '; | ||
| execSyncMock.mockImplementation((cmd: string) => { | ||
| if (typeof cmd === 'string' && cmd.includes('CLAUDE_CONFIG_DIR')) { | ||
| return '/shell/custom/claude\n'; | ||
| } | ||
| return ''; | ||
| }); | ||
|
|
||
| const { initializeShellEnvironment } = await import('../../main/utils/shellEnv'); | ||
| initializeShellEnvironment(); | ||
|
|
||
| expect(process.env.CLAUDE_CONFIG_DIR).toBe('/shell/custom/claude'); | ||
| }); | ||
|
|
||
| it('trims a padded CLAUDE_CONFIG_DIR already present in process.env', async () => { | ||
| process.env.CLAUDE_CONFIG_DIR = ' /existing/path '; | ||
| execSyncMock.mockReturnValue('/shell/custom/claude\n'); | ||
|
|
||
| const { initializeShellEnvironment } = await import('../../main/utils/shellEnv'); | ||
| initializeShellEnvironment(); | ||
|
|
||
| expect(process.env.CLAUDE_CONFIG_DIR).toBe('/existing/path'); | ||
| }); | ||
|
|
||
| it('leaves CLAUDE_CONFIG_DIR unset when the shell returns nothing', async () => { | ||
| execSyncMock.mockReturnValue(''); | ||
|
|
||
| const { initializeShellEnvironment } = await import('../../main/utils/shellEnv'); | ||
| initializeShellEnvironment(); | ||
|
|
||
| expect(process.env.CLAUDE_CONFIG_DIR).toBeUndefined(); | ||
| }); | ||
| }); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.