fix: remove max-w-4xl and drop Ctrl+Z to let terminal fill available width#1659
fix: remove max-w-4xl and drop Ctrl+Z to let terminal fill available width#1659yuzhichang wants to merge 2 commits intogeneralaction:mainfrom
Conversation
Terminal containers in ChatInterface and MultiAgentTask were capped at 896px regardless of window width. Changed to w-full so the terminal scales with the window, addressing the wasted horizontal space issue. Fixes generalaction#1650 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
When Ctrl+Z is pressed in emdash's terminal running an agent, SIGTSTP is sent to the foreground process group, causing the shell chain (bash -ilc "claude; exec bash -il") to deadlock — the agent stops but the shell can't fg it because exec never runs and no foreground process remains. The fix drops \x1a at the PTY write level so SIGTSTP is never generated, while preserving Ctrl+C (\x03) so users can still interrupt agent actions. Also removes 'exec' from the shell chain so the resume shell runs as a proper foreground child process. Fixes generalaction#1650 (related job control issue) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
@yuzhichang is attempting to deploy a commit to the General Action Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughChanges modify shell command chaining in the PTY manager to remove exec-based process control, add PTY input filtering to prevent Ctrl+Z signal generation, and update terminal container CSS classes from fixed max-width ( Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Two fixes for terminal UX issues:
Terminal width: Removes
max-w-4xlfromChatInterface.tsxandMultiAgentTask.tsxterminal containers. The terminal was capped at 896px regardless of window width, wasting horizontal space on wide monitors.Ctrl+Z deadlock: Drops
\x1a(SIGTSTP) at the PTY write level inwritePty(). When Ctrl+Z is pressed in emdash's terminal running an agent, the shell chain (bash -ilc "claude; exec bash -il") would deadlock — the agent stops butexec bash -ilnever runs, leaving no foreground process to handlefg. Also removesexecfrom the shell chain so the resume shell runs as a proper foreground child. Ctrl+C (\x03) is preserved so users can still interrupt agent actions.Fixes #1650
Test plan
🤖 Generated with Claude Code
Summary by CodeRabbit
Release Notes
Bug Fixes
UI Improvements
Improvements