fix(build): replace SiCss3 with SiCss for react-icons 5.6.0 compatibility#1663
fix(build): replace SiCss3 with SiCss for react-icons 5.6.0 compatibility#1663tpaustin wants to merge 1 commit intogeneralaction:mainfrom
Conversation
…lity SiCss3 was removed from react-icons in 5.6.0. Replace it with the new SiCss export and bump the minimum version to ^5.6.0 so the dependency and the code are in sync. Closes generalaction#1662 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
@tpaustin is attempting to deploy a commit to the General Action Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughUpdated Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
SiCss3export with the newSiCssexport inFileIcons.tsxreact-iconsversion to^5.6.0so the dependency and the code are in syncBackground
SiCss3was removed fromreact-iconsin 5.6.0. The currentpackage.jsonspecifies^5.5.0, which allows 5.6.0. Thepnpm-lock.yamlstill pins to 5.5.0, so contributors with the lockfile intact are unaffected today — but anyone whose lockfile resolves to 5.6.0 hits an immediate build failure:Bumping to
^5.6.0makes the lock consistent and prevents the breakage for any contributor who runspnpm installgoing forward.Test plan
pnpm run buildpassespnpm run type-checkpassesCloses #1662
🤖 Generated with Claude Code
Summary by CodeRabbit
Chores
react-iconsdependency to the latest version.Style