Add checkbox for GitHub branch deletion and fix API type inconsistencies #473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace getVersion with getAppVersion/getElectronVersion in preload and type definitions - Ensure single source of truth for Electron API types across preload.ts, electron-api.d.ts, and global.d.ts - Fix platform-specific shell command quoting in appIpc.ts (use double quotes on Windows, proper single quote escaping on POSIX) - Remove duplicate/conflicting ElectronAPI interface declarations All tests pass (type-check, lint, vitest)
|
@notkainoa is attempting to deploy a commit to the General Action Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds remote branch deletion, consolidates Electron API types, and improves shell command quoting for reliable project opening on Windows, macOS, and Linux. Sorry the pr's kinda big I got carried away :)
What’s new
You can delete remote GitHub branches without leaving the app. When you delete a task that links to a remote branch, you can delete the branch at the same time.
Improved type safety
Electron API type definitions are now consistent across the app. We use getAppVersion and getElectronVersion everywhere to reduce TypeScript errors and keep preload and renderer types in sync.
Better cross‑platform support
File paths with spaces now work reliably when opening projects in tools like VS Code, Cursor, Finder, and Linux terminals by using correct quoting rules per platform.
Technical details
Tests