refactor: use shadcn dialog for home screen modals #507
Conversation
|
@gontsolov is attempting to deploy a commit to the General Action Team on Vercel. A member of the Team first needs to authorize it. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
|
|
||
| if (!isOpen) return null; | ||
| return ( | ||
| <Dialog open={isOpen} onOpenChange={onClose}> |
There was a problem hiding this comment.
Dialog can close during ongoing async operations
The refactoring from custom modals to shadcn Dialog removed protection against closing during async operations. Previously, the X button had disabled={isCloning} / disabled={isCreating}, but now onOpenChange={onClose} allows closing via X button, Escape key, or clicking outside while operations are in progress. The Cancel button still respects this state, creating an inconsistency. Users may accidentally dismiss the dialog mid-operation, causing the async clone/create to run headless in the background.
Additional Locations (1)
2 participants
Note
Replaces custom motion/portal modals in
CloneFromUrlModalandNewProjectModalwith a reusable Radix-basedDialog, adding a newui/dialogcomponent and the@radix-ui/react-dialogdependency.src/renderer/components/CloneFromUrlModal.tsxandNewProjectModal.tsxto useDialog,DialogContent,DialogHeader,DialogTitle; remove custom motion/portal/card implementations.src/renderer/components/ui/dialog.tsxexporting a shadcn-style wrapper around@radix-ui/react-dialog(overlay, content, header/footer, title/description, close button).@radix-ui/react-dialogtodependencies.Written by Cursor Bugbot for commit 63d54db. This will update automatically on new commits. Configure here.