Reduce Redis EXPIRE calls using CustomRedisSessionStoreCustom redis session store #1221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 3, 2025 10:09
claudiamurialdo
temporarily deployed
to
kafka-integration-tests
GitHub Actions
Inactive
claudiamurialdo
temporarily deployed
to
external-storage-tests
GitHub Actions
Inactive
Collaborator
fedeazzato
approved these changes
Nov 4, 2025
Member
fedeazzato
left a comment
fedeazzato
left a comment
There was a problem hiding this comment.
I'm struggling to see how the tradeoff between the increase in TTL invocations results in performance gains due to the reduction of EXIPRE invocations, but I trust your findings.
Comment on lines
+96
to
+100
| var ttl = await _db.KeyTimeToLiveAsync(redisKey); | ||
|
|
||
| if (ShouldRefreshKey(ttl)) | ||
| { | ||
| _ = _db.KeyExpireAsync(redisKey, _idleTimeout); |
Member
There was a problem hiding this comment.
Is it really more performant to check for the TTL (invoking a Redis operation) before expiring the key? Isn't the Redis endpoint hit anyway?
Shouldn't the invocation to KeyExpireAsync be awaited?
Comment on lines
+78
to
+83
| var ttl = _db.KeyTimeToLive(redisKey); | ||
|
|
||
| if (ShouldRefreshKey(ttl)) | ||
| { | ||
| _db.KeyExpire(redisKey, _idleTimeout); | ||
| } |
Member
There was a problem hiding this comment.
Same here. How checking for TTL before invoking expire results in performance gains, if both must reach a Redis?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the default RedisCache behavior (https://github.com/dotnet/aspnetcore/blob/main/src/Caching/StackExchangeRedis/src/RedisCache.cs) , which refreshes the session TTL on every access to the web session, with a custom implementation that renews it only when near expiry (below 20% of the idle timeout).
This reduces redundant EXPIRE calls and Redis roundtrips while maintaining consistent session expiration behavior.
Issue:206131