Skip to content

Pdf box memory usage #918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 17, 2024
Merged

Pdf box memory usage #918

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a1b18c4
Encode with UTF-8 if getString has funny characters
tomas-sexenian Nov 2, 2024
0101ba9
Merge remote-tracking branch 'origin/master'
tomas-sexenian Nov 12, 2024
dcd7b2c
Merge remote-tracking branch 'origin/master'
tomas-sexenian Nov 27, 2024
e242950
Fix streams concurrency issues
tomas-sexenian Nov 30, 2024
1c3443a
Bump PDFBox to 3.0.3 and improve memory usage
tomas-sexenian Dec 6, 2024
5f543ce
Fix font loading
tomas-sexenian Dec 13, 2024
de0d991
Merge branch 'master' into PDFBoxMemoryUsage
iroqueta Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion java/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@
<dependency>
<groupId>org.apache.pdfbox</groupId>
<artifactId>pdfbox</artifactId>
<version>2.0.27</version>
<version>3.0.3</version>
</dependency>
<dependency>
<groupId>org.jsoup</groupId>
Expand Down
17 changes: 5 additions & 12 deletions java/src/main/java/com/genexus/internet/HttpClientJavaLib.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -718,23 +718,16 @@ public String getString() {
return "";
try {
this.setEntity();
ContentType contentType = ContentType.getOrDefault(entity);
Charset charset;
if (contentType.equals(ContentType.DEFAULT_TEXT)) {
charset = StandardCharsets.UTF_8;
} else {
charset = contentType.getCharset();
if (charset == null) {
charset = StandardCharsets.UTF_8;
}
}
Charset charset = ContentType.getOrDefault(entity).getCharset();
String res = EntityUtils.toString(entity, charset);
if (res.matches(".*[Ã-ÿ].*")) {
res = EntityUtils.toString(entity, StandardCharsets.UTF_8);
}
eof = true;
return res;
} catch (IOException e) {
setExceptionsCatch(e);
} catch (IllegalArgumentException e) {
}
} catch (IllegalArgumentException e) {}
return "";
}

Expand Down
Loading
Loading