migrate smart-order router for SLV orders#119
Draft
irfanaligy wants to merge 9 commits intogeniusyield:mainfrom
Draft
migrate smart-order router for SLV orders#119irfanaligy wants to merge 9 commits intogeniusyield:mainfrom
irfanaligy wants to merge 9 commits intogeniusyield:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
draft PR for SLV migration. compiles and runs but testing with actual two-way orders needed.
key files are
Types.hs,Oracle.hs,MatchingStrategy.hs,OrderBot.hs@brunjlar the issue of incoherent placed order has not been handled yet pending some clarification about where to add it. i was wondering if it would be possible to completely reject such orders right at the point where we make abstracted
OrderInfofrom theTwoWayOrderInfoso there is no possibility of misuse.