chore(js/plugins/googleai): Completely remove deprecated googleai plugin plus#4948
chore(js/plugins/googleai): Completely remove deprecated googleai plugin plus#4948
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses several maintenance tasks, including deprecating the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request includes changes to the google-genai and vertexai plugins, focusing on removing the deprecated googleai plugin and fixing a bug in the imagen parameter handling. The vertexai plugin also receives a deprecation warning. The changes in imagen.ts and converters.ts ensure that falsy parameters like false and 0 are correctly handled, while undefined and null values are removed. Tests are updated to reflect these changes.
…other chores:
falseand0(but still not undefined or null).Checklist (if applicable):