Skip to content

fix(go/plugins/googlegenai): add support to IncludeServerSideToolInvocations#4971

Open
Gerifield wants to merge 1 commit intogenkit-ai:mainfrom
Gerifield:main
Open

fix(go/plugins/googlegenai): add support to IncludeServerSideToolInvocations#4971
Gerifield wants to merge 1 commit intogenkit-ai:mainfrom
Gerifield:main

Conversation

@Gerifield
Copy link

ISSUE: #4970

CHANGELOG:

  • Update genai toGeminiToolChoice function to not overwrite the tool config if it exists

Checklist (if applicable):

…ludeServerSideToolInvocations

ISSUE: genkit-ai#4970

CHANGELOG:
  - [ ] Update genai toGeminiToolChoice function to not overwrite the tool config if it exists
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the googlegenai plugin by updating its core dependency and refining the logic for handling tool configurations. The primary goal is to ensure that existing tool configurations, particularly those related to server-side tool invocations, are preserved when applying new function calling settings, thereby preventing data loss and improving the robustness of tool integration.

Highlights

  • Dependency Update: The google.golang.org/genai dependency has been updated from v1.41.0 to v1.51.0.
  • Tool Configuration Logic Refinement: The toGeminiToolChoice function now accepts an existing ToolConfig and updates its FunctionCallingConfig if present, preventing unintended overwrites of other tool configuration settings like IncludeServerSideToolInvocations.
  • Function Signature Change: The toGeminiToolChoice function signature in go/plugins/googlegenai/tools.go was modified to include an initial toolConfig parameter.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the google.golang.org/genai dependency from v1.41.0 to v1.51.0. Correspondingly, the toGeminiToolChoice function in the googlegenai plugin has been refactored to accept an existing genai.ToolConfig as an argument. If an existing configuration is provided, the function now updates its FunctionCallingConfig with the specified mode and allowed function names, rather than always creating a new genai.ToolConfig.

@Gerifield
Copy link
Author

Here is an example config how to test/trigger it:

ist := true
geminiSpecConfig := &genai.GenerateContentConfig{
		ToolConfig: &genai.ToolConfig{
			IncludeServerSideToolInvocations: &ist,
		},
		Tools: []*genai.Tool{
			{GoogleSearch: &genai.GoogleSearch{}},
		}
	}

Then it can be added to the Generate option via: ai.WithConfig(geminiSpecConfig)
If there are tools added with the ai.WithTools command, it should still work and do it's job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant