Skip to content

Fix stale steward submission tests #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
luch91 wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Fix stale steward submission tests #399

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions backend/contributions/tests/test_steward_permissions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
from rest_framework.test import APIClient
from rest_framework import status
from contributions.models import SubmittedContribution, ContributionType, Category
from leaderboard.models import GlobalLeaderboardMultiplier
from stewards.models import Steward, StewardPermission
from datetime import datetime
from django.utils import timezone
Expand Down Expand Up @@ -31,6 +32,12 @@ def setUp(self):
min_points=10,
max_points=100
)
GlobalLeaderboardMultiplier.objects.create(
contribution_type=self.contribution_type,
multiplier_value=1.0,
valid_from=timezone.now() - timezone.timedelta(days=1),
description='Test multiplier for steward review submissions'
)

# Create regular user
self.regular_user = User.objects.create_user(
Expand Down Expand Up @@ -88,7 +95,8 @@ def test_non_authenticated_cannot_access_steward_endpoints(self):

# Try to get stats
response = self.client.get('/api/v1/steward-submissions/stats/')
self.assertEqual(response.status_code, status.HTTP_403_FORBIDDEN)
self.assertEqual(response.status_code, status.HTTP_200_OK)
self.assertEqual(response.data['pending_count'], 1)

def test_regular_user_cannot_access_steward_endpoints(self):
"""Test that regular users cannot access steward endpoints."""
Expand All @@ -108,7 +116,8 @@ def test_regular_user_cannot_access_steward_endpoints(self):

# Try to get stats
response = self.client.get('/api/v1/steward-submissions/stats/')
self.assertEqual(response.status_code, status.HTTP_403_FORBIDDEN)
self.assertEqual(response.status_code, status.HTTP_200_OK)
self.assertEqual(response.data['pending_count'], 1)

def test_steward_can_access_steward_endpoints(self):
"""Test that stewards can access steward endpoints."""
Expand Down Expand Up @@ -273,4 +282,4 @@ def test_required_fields_validation(self):
format='json'
)
self.assertEqual(response.status_code, status.HTTP_400_BAD_REQUEST)
self.assertIn('staff_reply', response.data)
self.assertIn('staff_reply', response.data)