Skip to content

Conversation

@belisas
Copy link

@belisas belisas commented Nov 24, 2025

@belisas belisas marked this pull request as draft November 24, 2025 13:10
@belisas belisas force-pushed the develop-2025-12-17 branch from 342a02e to 255d592 Compare December 1, 2025 11:56
belisas and others added 7 commits December 1, 2025 13:54
cchag: Layout corrections 2

cchag: Layout corrections 2

cchag: Layout corrections 4
With PB-2045, now also the release notes are checked by the formatter (prettier).

This commit applies that formatting (`npm run format`) such that the format check passes (`npm run format:check`).

The format check is also run by CodeBuild, so fixing this is not optional.
@asteiner-swisstopo
Copy link
Contributor

@belisas, FYI: I have updated the Markdown format of your newly added file because since #95 the release notes are also checked by the formatter. See commit 166b4da for details.

@belisas
Copy link
Author

belisas commented Dec 1, 2025

@asteiner-swisstopo Thank you very much! Just one question: how do I best add the correct amount of spaces for an entry when updating the release notes? Calculating by hand seems a bit tedious and in VS, the file doesn't show proper formattting despite being defined as markdown.
Screenshot from 2025-12-01 14-51-35

@asteiner-swisstopo
Copy link
Contributor

@asteiner-swisstopo Thank you very much! Just one question: how do I best add the correct amount of spaces for an entry when updating the release notes?

To make it easier visually to adapt whitespace by hand, I suggest turning off word wrapping in you editor (in vscode: "View" > "Word Wrap"). So it looks like this:
image

You could also tell vscode to run the formatter (prettier) upon every save:

  1. Install a prettier plugin, for example JavaScript prettier.
  2. Configure it to match what our CI runs.
  3. Set"editor.formatOnSave": true in the settings.json.

What I do and is probably good enough: Just run npm run format when I think I'm done.

@belisas
Copy link
Author

belisas commented Dec 1, 2025

Thank you very much for these recommendations, @asteiner-swisstopo! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants